Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5745200B36 for ; Wed, 6 Jul 2016 09:49:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B40A3160A74; Wed, 6 Jul 2016 07:49:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2CF11160A64 for ; Wed, 6 Jul 2016 09:49:12 +0200 (CEST) Received: (qmail 45150 invoked by uid 500); 6 Jul 2016 07:49:11 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 45084 invoked by uid 99); 6 Jul 2016 07:49:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2016 07:49:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 11B762C02A5 for ; Wed, 6 Jul 2016 07:49:11 +0000 (UTC) Date: Wed, 6 Jul 2016 07:49:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1248) FastDatePrinter Memory allocation regression MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Jul 2016 07:49:12 -0000 [ https://issues.apache.org/jira/browse/LANG-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363929#comment-15363929 ] ASF GitHub Bot commented on LANG-1248: -------------------------------------- Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/169 [![Coverage Status](https://coveralls.io/builds/6884804/badge)](https://coveralls.io/builds/6884804) Coverage decreased (-0.03%) to 93.417% when pulling **d201ad32af1e71140539fbd7efe701f6b2e89ffe on benbenw:LANG-1248** into **ce0c082898e3551d313fb5b73763f399232b3fd5 on apache:master**. > FastDatePrinter Memory allocation regression > -------------------------------------------- > > Key: LANG-1248 > URL: https://issues.apache.org/jira/browse/LANG-1248 > Project: Commons Lang > Issue Type: Bug > Components: lang.time.* > Affects Versions: 3.5 > Reporter: Benoit Wiart > > when the code was migrated from StringBuffer to Appendable in LANG-1152. > We've lost the ability to modify the buffer (setCharAt) > The new implementation of appendFullDigits allocate a temporary char array to work around that limitation. > This is a major source of memory allocation which is not present in version 3.4. -- This message was sent by Atlassian JIRA (v6.3.4#6332)