Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 5 Jul 2016 20:53:11 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12986838.1467730444000.30043.1467751991233@Atlassian.JIRA>
In-Reply-To: <JIRA.12986838.1467730444000@Atlassian.JIRA>
References: <JIRA.12986838.1467730444000@Atlassian.JIRA> <JIRA.12986838.1467730444206@arcas>
Subject: [jira] [Commented] (LANG-1248) FastDatePrinter Memory allocation
 regression
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Jul 2016 20:53:13 -0000


    [ https://issues.apache.org/jira/browse/LANG-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363223#comment-15363223 ] 

Sebb commented on LANG-1248:
----------------------------

Another possible approach is to check for an instance of AbstractStringBuffer; if so, then use setCharAt(int, char)

In the case of CharBuffer, one can use put(int, char)

In any other case (e.g. PrintStream or Writer), use the existing implementation.

That should reduce the memory allocation for the commonest cases.

> FastDatePrinter Memory allocation regression
> --------------------------------------------
>
>                 Key: LANG-1248
>                 URL: https://issues.apache.org/jira/browse/LANG-1248
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.time.*
>    Affects Versions: 3.5
>            Reporter: Benoit Wiart
>
> when the code was migrated from StringBuffer to Appendable in LANG-1152.
> We've lost the ability to modify the buffer (setCharAt) 
> The new implementation of appendFullDigits allocate a temporary char array to work around that limitation.
> This is a major source of memory allocation which is not present in version 3.4.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)