Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 279B0200B62 for ; Fri, 29 Jul 2016 02:31:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 26426160AA9; Fri, 29 Jul 2016 00:31:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 95CD9160A94 for ; Fri, 29 Jul 2016 02:31:21 +0200 (CEST) Received: (qmail 22717 invoked by uid 500); 29 Jul 2016 00:31:20 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 22690 invoked by uid 99); 29 Jul 2016 00:31:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2016 00:31:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 76FF22C0D5E for ; Fri, 29 Jul 2016 00:31:20 +0000 (UTC) Date: Fri, 29 Jul 2016 00:31:20 +0000 (UTC) From: "Matt Sicker (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DBCP-436) Avoid executing ROLLBACK when transaction is not active MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 29 Jul 2016 00:31:22 -0000 [ https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398498#comment-15398498 ] Matt Sicker commented on DBCP-436: ---------------------------------- I updated the fix version to 2.3, but it looks like you guys wanna close this. > Avoid executing ROLLBACK when transaction is not active > ------------------------------------------------------- > > Key: DBCP-436 > URL: https://issues.apache.org/jira/browse/DBCP-436 > Project: Commons Dbcp > Issue Type: Improvement > Reporter: Michael Mikhulya > Labels: performance > Fix For: 2.3 > > > {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on the connection as it is returned to the pool. > It hurts performance. > I suggest to don't call {{rollback}} if transaction is not active. > Such improvement is done in HikariCP: > https://github.com/brettwooldridge/HikariCP/issues/177 -- This message was sent by Atlassian JIRA (v6.3.4#6332)