commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "glease w. (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-1250) SerializationUtils::deserialize has unnecessary code and a comment for that
Date Wed, 20 Jul 2016 03:37:20 GMT
glease w. created LANG-1250:
-------------------------------

             Summary: SerializationUtils::deserialize has unnecessary code and a comment for
that
                 Key: LANG-1250
                 URL: https://issues.apache.org/jira/browse/LANG-1250
             Project: Commons Lang
          Issue Type: Improvement
          Components: lang.*
    Affects Versions: 3.4
            Reporter: glease w.
            Priority: Trivial
             Fix For: 3.x


In org.apache.commons.lang3.SerializationUtils L219-L227: 

{quote}
        try \{
            // stream closed in the finally
            in = new ObjectInputStream(inputStream);
            @SuppressWarnings("unchecked") // may fail with CCE if serialised form is incorrect
            final T obj = (T) in.readObject();
            return obj;

        } catch (final ClassCastException ex) \{
            throw new SerializationException(ex);
{quote}


and in the javadoc: 

{quote}
     \* 
     \* <p>
     \* If the call site incorrectly types the return value, a \{@link ClassCastException}
is thrown from the call site.
     \* Without Generics in this declaration, the call site must type cast and can cause the
same ClassCastException.
     \* Note that in both cases, {color:red}the ClassCastException is in the call site, not
in this method.{color}
     \* </p>
     \*
{quote}

There is a conflict. The first catch block and that inlined comment needs to be removed. I'll
submit a patch via github soon.

 Blame showed the javadoc and code are written by indiviual person in different years, so
that may be the cause. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message