commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BCEL-262) InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array
Date Thu, 07 Jul 2016 16:39:11 GMT

     [ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Roberts updated BCEL-262:
------------------------------
    Attachment: bug262.diff

I have attached unit test to demonstrate problem.

> InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects
an array
> --------------------------------------------------------------------------------------------------
>
>                 Key: BCEL-262
>                 URL: https://issues.apache.org/jira/browse/BCEL-262
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>            Assignee: Benedikt Ritter
>             Fix For: 6.0
>
>         Attachments: InvokeInstruction.diff, bug262.diff
>
>
> The method FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated because it can
return java.lang.Object for arrays.
> Now the method is defined in the superclass for FieldInstructions and InvokeInstructions.
> In the case of InvokeInstructions, can these ever reference an Array?
> If not, then the method could be overridden in the InvokeInstruction class.
> This new method would throw an unchecked Exception if detects an Array.
> This would change the behaviour of the method for subclasses of InvokeInstruction, but
they would not need to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message