Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 30 Jun 2016 11:29:10 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12985722.1467286121000.3039.1467286150390@Atlassian.JIRA>
In-Reply-To: <JIRA.12985722.1467286121000@Atlassian.JIRA>
References: <JIRA.12985722.1467286121000@Atlassian.JIRA> <JIRA.12985722.1467286121194@arcas>
Subject: [jira] [Created] (CRYPTO-95) Code should never catch Throwable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 30 Jun 2016 11:29:12 -0000

Sebb created CRYPTO-95:
--------------------------

             Summary: Code should never catch Throwable
                 Key: CRYPTO-95
                 URL: https://issues.apache.org/jira/browse/CRYPTO-95
             Project: Commons Crypto
          Issue Type: Bug
            Reporter: Sebb


As a general rule, code should never catch Throwable or Error, only Exception.

Sometimes it is necessary to catch more than just Exception, but if so, the code must be careful to rethrow certain errors, e.g.

ThreadDeath
VirtualMachineError

There may be some others

If the throwable is not logged, then it's vital to ensure that only the appropriate ones are swallowed.

But it is better to be explicit and only catch errors which are safe to handle.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)