Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 65CA7200B32 for ; Wed, 8 Jun 2016 16:52:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 648A5160A2E; Wed, 8 Jun 2016 14:52:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8818160A0E for ; Wed, 8 Jun 2016 16:52:23 +0200 (CEST) Received: (qmail 10651 invoked by uid 500); 8 Jun 2016 14:52:21 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 9439 invoked by uid 99); 8 Jun 2016 14:52:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2016 14:52:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3C9A92C1F70 for ; Wed, 8 Jun 2016 14:52:21 +0000 (UTC) Date: Wed, 8 Jun 2016 14:52:21 +0000 (UTC) From: "Joerg Schaible (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (COLLECTIONS-590) MapUtils.EMPTY_SORTED_MAP should be renamed - UnmodifiableSortedMap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Jun 2016 14:52:24 -0000 [ https://issues.apache.org/jira/browse/COLLECTIONS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Schaible resolved COLLECTIONS-590. ---------------------------------------- Resolution: Won't Fix The names follow the same logic as their counter parts in the JDK. An empty sorted map is always empty and therefore implicitly unmodifiable. > MapUtils.EMPTY_SORTED_MAP should be renamed - UnmodifiableSortedMap > ------------------------------------------------------------------- > > Key: COLLECTIONS-590 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-590 > Project: Commons Collections > Issue Type: Improvement > Reporter: Philipp Schneider > Priority: Minor > > When using the constant MapUtils.EMPTY_SORTED_MAP I assume from the name, that it will return an empty sorted map. > But the map is an UnmodifiableSortedMap. > The Javadoc says this, but still the naming is not really good. > I suggest the following new name: EMPTY_UNMODIFIABLE_SORTED_MAP -- This message was sent by Atlassian JIRA (v6.3.4#6332)