Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DD4C8200B0F for ; Fri, 17 Jun 2016 22:41:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DBEB8160A61; Fri, 17 Jun 2016 20:41:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56037160A4C for ; Fri, 17 Jun 2016 22:41:11 +0200 (CEST) Received: (qmail 46745 invoked by uid 500); 17 Jun 2016 20:41:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 46711 invoked by uid 99); 17 Jun 2016 20:41:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 20:41:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4DE8C2C14F9 for ; Fri, 17 Jun 2016 20:41:05 +0000 (UTC) Date: Fri, 17 Jun 2016 20:41:05 +0000 (UTC) From: "Karl D. Gierach (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MATH-1373) In LogNormalDistribution.java, it appears shape & scale are reversed/mis-labelled. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Jun 2016 20:41:12 -0000 [ https://issues.apache.org/jira/browse/MATH-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336901#comment-15336901 ] Karl D. Gierach commented on MATH-1373: --------------------------------------- I will come up with a patch based on github: http://git-wip-us.apache.org/repos/asf/commons-math.git Also, it appears the parameters are reversed in getNumericalVariance() as well. Sound OK? Thanks, Karl > In LogNormalDistribution.java, it appears shape & scale are reversed/mis-labelled. > ---------------------------------------------------------------------------------- > > Key: MATH-1373 > URL: https://issues.apache.org/jira/browse/MATH-1373 > Project: Commons Math > Issue Type: Bug > Affects Versions: 3.6.1 > Reporter: Karl D. Gierach > Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When I compute the logshape and log scale based on the formulas on wikipedia's lognormal distribution page that use empirical mean and variance, I found that the getNumericalMean() method was not returning the empirical mean. > However, upon just trying to reverse the shape and scale parameters in the constructor proved to fix the problem, and the object then returns the correct empirical mean. -- This message was sent by Atlassian JIRA (v6.3.4#6332)