Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 30BED200B44 for ; Thu, 30 Jun 2016 07:29:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2F572160A57; Thu, 30 Jun 2016 05:29:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 747E5160A6E for ; Thu, 30 Jun 2016 07:29:12 +0200 (CEST) Received: (qmail 55915 invoked by uid 500); 30 Jun 2016 05:29:10 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 55450 invoked by uid 99); 30 Jun 2016 05:29:10 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2016 05:29:10 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 21AD92C02A3 for ; Thu, 30 Jun 2016 05:29:10 +0000 (UTC) Date: Thu, 30 Jun 2016 05:29:10 +0000 (UTC) From: "Dapeng Sun (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CRYPTO-63) Add JNA binding MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Jun 2016 05:29:13 -0000 [ https://issues.apache.org/jira/browse/CRYPTO-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356542#comment-15356542 ] Dapeng Sun edited comment on CRYPTO-63 at 6/30/16 5:28 AM: ----------------------------------------------------------- Thank Sebb for your comments, {quote} Note that JNA covers far more OSes than the JNI code, so it may be the only way to make OpenSSL available on many platforms. Unless there are serious problems with it, I think it would be better to include the code, but include a warning in the documentation / release notes that it may not be as reliable or performant as the JNI code. Users won't get the JNA version unless they ask for it. For some platforms it may be the best choice. {quote} I'm agree that JNA is an important feature, but I think moving JNA to next release should be also reasonable. If JNA feature is strong demanded, we can speed up the progress of the JNA release. was (Author: dapengsun): Thank Sebb for your comments, {quote} Note that JNA covers far more OSes than the JNI code, so it may be the only way to make OpenSSL available on many platforms. Unless there are serious problems with it, I think it would be better to include the code, but include a warning in the documentation / release notes that it may not be as reliable or performant as the JNI code. Users won't get the JNA version unless they ask for it. For some platforms it may be the best choice. {quote} I'm agree that JNA is an important feature, but I think move to next release should be also reasonable. If JNA feature is strong demanded, we can speed up the progress of the JNA release. > Add JNA binding > --------------- > > Key: CRYPTO-63 > URL: https://issues.apache.org/jira/browse/CRYPTO-63 > Project: Commons Crypto > Issue Type: Improvement > Reporter: Hendrik Saly > Assignee: Hendrik Saly > > Needs benchmarking before merge. > PR https://github.com/apache/commons-crypto/pull/47 -- This message was sent by Atlassian JIRA (v6.3.4#6332)