commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xianda Ke (JIRA)" <>
Subject [jira] [Commented] (CRYPTO-86) What purpose does the Properties instance serve?
Date Tue, 21 Jun 2016 07:29:57 GMT


Xianda Ke commented on CRYPTO-86:

Properties instance was used only in PositionedCryptoInputStream.getCipherState().
                cipher = CryptoCipherFactory.getInstance(getCipher()
                        .getTransformation(), getCipher().getProperties());
agree with []. Since PositionedCryptoInputStream itself has Properties parameters,
there is no need to hold the Properties reference in CryptoCipher.

GitHub PR:

> What purpose does the Properties instance serve?
> ------------------------------------------------
>                 Key: CRYPTO-86
>                 URL:
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
> The CrytoCipher implementations currently store a reference to a Properties instance.
> However it does not appear to be used by the class except to create a new instance of
the class.
> It looks like the field could be dropped entirely.

This message was sent by Atlassian JIRA

View raw message