commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dapeng Sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRYPTO-83) Utils.getRandomDevPath should be private method in OsCryptoRandom
Date Fri, 24 Jun 2016 06:24:16 GMT

    [ https://issues.apache.org/jira/browse/CRYPTO-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347825#comment-15347825
] 

Dapeng Sun commented on CRYPTO-83:
----------------------------------

Committed to master, thank Sebb
CRYPTO-83: Utils.getRandomDevPath should be private method in OsCryptoRandom


Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/7c328f25
Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/7c328f25
Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/7c328f25


> Utils.getRandomDevPath should be private method in OsCryptoRandom
> -----------------------------------------------------------------
>
>                 Key: CRYPTO-83
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-83
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Dapeng Sun
>            Priority: Minor
>
> The method Utils.getRandomDevPath is only used from OsCryptoRandom and should probably
be moved there.
> Likewise the default value constant
> COMMONS_CRYPTO_SECURE_RANDOM_DEVICE_FILE_PATH_DEFAULT
> does not really make much sense except to the OsCryptoRandom class.
> Note: property key names do need to be centrally defined to avoid duplication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message