commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRYPTO-72) CryptoCipherFactory.getInstance does unnecessary class instantiation
Date Mon, 20 Jun 2016 09:21:05 GMT

    [ https://issues.apache.org/jira/browse/CRYPTO-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339212#comment-15339212
] 

Sebb commented on CRYPTO-72:
----------------------------

In future, please use separate commits for separate issues.

> CryptoCipherFactory.getInstance does unnecessary class instantiation
> --------------------------------------------------------------------
>
>                 Key: CRYPTO-72
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-72
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>
> The CryptoCipherFactory.getInstance method calls getCipherClasses which splits the string
containing the class name(s) and then creates an instance of each (if possible) using ReflectionUtils.getClassByName.
> However the getInstance method stops processing on the first successful class, so any
subsequent entries are not used.
> This is wasteful; the call to ReflectionUtils.getClassByName should only be done if it
is going to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message