commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dapeng Sun (JIRA)" <>
Subject [jira] [Commented] (CRYPTO-72) CryptoCipherFactory.getInstance does unnecessary class instantiation
Date Mon, 20 Jun 2016 07:56:05 GMT


Dapeng Sun commented on CRYPTO-72:

Thank Sebb for filing the issue, I think the issue have been fixed at CRYPTO-76, please feel
free to reopen if necessary. 

CRYPTO-76: Remove log dependence


> CryptoCipherFactory.getInstance does unnecessary class instantiation
> --------------------------------------------------------------------
>                 Key: CRYPTO-72
>                 URL:
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
> The CryptoCipherFactory.getInstance method calls getCipherClasses which splits the string
containing the class name(s) and then creates an instance of each (if possible) using ReflectionUtils.getClassByName.
> However the getInstance method stops processing on the first successful class, so any
subsequent entries are not used.
> This is wasteful; the call to ReflectionUtils.getClassByName should only be done if it
is going to be used.

This message was sent by Atlassian JIRA

View raw message