commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BCEL-273) Regressions running FindBugs on BCEL6
Date Thu, 09 Jun 2016 09:58:21 GMT

    [ https://issues.apache.org/jira/browse/BCEL-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322274#comment-15322274
] 

Sebb edited comment on BCEL-273 at 6/9/16 9:58 AM:
---------------------------------------------------

The stack trace looks very odd.

It looks like you are mixing two different versions of BCEL using different package names
and/or creating your own classes which are not BranchInstructions.

If the following patch comment is true, then there should be no reason for the CCE:

{code}
private BranchInstruction bi; // An alias in fact, but saves lots of casts
{code}

I'm not keen to re-introduce a local copy of the instruction, as it makes testing harder.
["If there are two copies of a piece of data, at least one of them may be wrong"]

I would rather see the casts.


was (Author: sebb@apache.org):
The stack trace looks very odd.

It looks like you are mixing two different versions of BCEL using different package names
and/or creating your own classes which are not BranchInstructions.

If the following patch comment is true, then there should be no reason for the CCE:

{code}
private BranchInstruction bi; // An alias in fact, but saves lots of casts
{code}

I'm not keep to re-introduce a local copy of the instruction, as it makes testing harder.
["If there are two copies of a piece of data, at least one of them may be wrong"]

I would rather see the casts.

> Regressions running FindBugs on BCEL6
> -------------------------------------
>
>                 Key: BCEL-273
>                 URL: https://issues.apache.org/jira/browse/BCEL-273
>             Project: Commons BCEL
>          Issue Type: Bug
>          Components: Main
>    Affects Versions: 6.0
>            Reporter: Andrey Loskutov
>            Priority: Blocker
>             Fix For: 6.0
>
>         Attachments: BetterCFGBuilder2.java, bcel6_test_result.txt, invokedynamic.txt
>
>
> h5. PREFACE
> I'm trying to port FindBugs to the latest greatest BCEL 6 state from trunk, see https://github.com/findbugsproject/findbugs/issues/106.
> In short, FindBugs was using some manually created BCEL 5.2 fork which allowed us somehow
run BCEL on Java 8 and even Java 9.
> Unfortunately I have no idea how to rebuild that fork, because no one in the project
left any documentation.
> So anyway, my goal was to use unmodified BCEL6, therefore I fixed all compile issues
caused by BCEL-222 ((n)) and was able to run FB with BCEL6 head.
>  
> Unfortunately I found some regressions.
> h5. Environment
> I'm using my own git clone from BCEL mirror https://github.com/iloveeclipse/commons-bcel/commits/trunk
> The clone only adds few Eclipse files and fixes some obvious errors, nothing worth to
mention here. The reason why I'm not using svn because it is too slow and I won't waste my
time.
> To see commits I needed to port FB to BCEL6 port, go to https://github.com/findbugsproject/findbugs/tree/java9_bcel6
> h5. How to reproduce
> {code}
> git clone https://github.com/findbugsproject/findbugs.git
> cd findbugs
> git checkout java9_bcel6
> cd findbugs
> ant
> cd ../findbugsTestCases
> ant
> {code}
> You should run Java 8.
> After running tests, you should see many various errors, like: https://github.com/findbugsproject/findbugs/files/300401/bcel6_test_result.txt
> None of those error appear with the old private patched BCEL5.2 snapshot we've used before.
> It would be nice to fix the errors before the BCEL release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message