commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BCEL-237) non-empty final arrays should be private as they are mutable
Date Sat, 18 Jun 2016 14:51:05 GMT

     [ https://issues.apache.org/jira/browse/BCEL-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved BCEL-237.
-----------------------
    Resolution: Fixed

Sorry, it was fixed, it's just that the original class was kept for compatibility (but deprecated)

However the BCEL code does not use the original class any more (it uses Const), so it does
not really matter if user code mutates any of the arrays.

> non-empty final arrays should be private as they are mutable
> ------------------------------------------------------------
>
>                 Key: BCEL-237
>                 URL: https://issues.apache.org/jira/browse/BCEL-237
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 6.0
>
>
> Final array elements are not themselves final.
> So any final arrays should always be private, otherwise external code can corrupt the
entries accidentally or deliberately.
> Either the array can be accessed through a getter that clones the contents, or the entries
can be accessed through a getter that returns a single entry.
> This issue affects:
> Constants.class:
> CONSTANT_NAMES
> ACCESS_NAMES
> INTERFACES_IMPLEMENTED_BY_ARRAYS
> TYPE_NAMES
> CLASS_TYPE_NAMES
> SHORT_TYPE_NAMES
> NO_OF_OPERANDS
> TYPE_OF_OPERANDS
> OPCODE_NAMES
> CONSUME_STACK
> PRODUCE_STACK
> ATTRIBUTE_NAMES
> ITEM_NAMES
> METHODHANDLE_NAMES



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message