commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...
Date Fri, 03 Jun 2016 14:36:24 GMT
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/137
  
    Thanks for updating the pull request. It looks good. :)
    
    Just two small issues:
    
    *  javadoc examples have to be updated for the `IllegalArgumentException` for negative
offset and length
    * checking offset and length should be done at the very start of the method (e.g. do not
allow a negative offset and/or length for a `null` string)
    
    Thanks,
    Pascal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message