Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 24 May 2016 15:05:13 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12971820.1463861505000.277291.1464102313092@Atlassian.JIRA>
In-Reply-To: <JIRA.12971820.1463861505000@Atlassian.JIRA>
References: <JIRA.12971820.1463861505000@Atlassian.JIRA> <JIRA.12971820.1463861505304@arcas>
Subject: [jira] [Commented] (LANG-1236) Add StopWatch#getTime with String
 Format Argument
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 24 May 2016 15:05:15 -0000


    [ https://issues.apache.org/jira/browse/LANG-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298321#comment-15298321 ] 

Sebb commented on LANG-1236:
----------------------------

-1

I'm not sure it makes sense to add formatting to the StopWatch class.

There are lots of other LANG methods that return numeric values which need to be formatted for output.

It would not make sense to add formatting to each and every one.
Better to create generic formatters for the various different numeric types.
This would also be much easier to test.

> Add StopWatch#getTime with String Format Argument
> -------------------------------------------------
>
>                 Key: LANG-1236
>                 URL: https://issues.apache.org/jira/browse/LANG-1236
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.time.*
>            Reporter: Nick Manley
>            Priority: Minor
>
> Add a version of the StopWatch#getTime method which takes a String to format the time in the desired format.
> {code}
> StopWatch watch= StopWatch.createStarted();
> // sleep for 1 hour, 19 minutes, 45.554 seconds
> try {Thread.sleep(4785554);} catch (final InterruptedException ex) {}
> watch.stop();
> System.out.println(watch.getTime("HH:mm:ss.SSS");
> // prints: 1:19:45.554
> {code}
> I have a patch ready, but I wasn't sure if this kind of thing should be a part of the getTime method or if toString should be overloaded to take a format argument. Either way seems okay to me. I put it on getTime, but if there are disagreements about that, I would be okay with putting it in toString instead.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)