Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 21 May 2016 20:15:13 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12971820.1463861505000.259875.1463861713023@Atlassian.JIRA>
In-Reply-To: <JIRA.12971820.1463861505000@Atlassian.JIRA>
References: <JIRA.12971820.1463861505000@Atlassian.JIRA> <JIRA.12971820.1463861505304@arcas>
Subject: [jira] [Commented] (LANG-1236) Add StopWatch#getTime with String
 Format Argument
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 21 May 2016 20:15:14 -0000


    [ https://issues.apache.org/jira/browse/LANG-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295239#comment-15295239 ] 

ASF GitHub Bot commented on LANG-1236:
--------------------------------------

GitHub user NickManley opened a pull request:

    https://github.com/apache/commons-lang/pull/153

    LANG-1236: Add StopWatch#getTime with String Format Argument

    I wasn't sure if this kind of thing should be a part of the getTime method or if toString should be overloaded to take a format argument. Either way seems okay to me. I put it on getTime, but if there are disagreements about that, I would be okay with putting it in toString instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NickManley/commons-lang formatted_getTime

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #153
    
----
commit 9f6797d93172b1d79298e5ca63e995f2242f3f04
Author: Nick Manley <nickmanley89@outlook.com>
Date:   2016-05-21T18:53:49Z

    LANG-1223: Add StopWatch#getTime(TimeUnit)

commit 82a58a0b11c3086781bd526dc596e33889bd3f3a
Author: Nick Manley <nickmanley89@outlook.com>
Date:   2016-05-21T20:06:06Z

    Add String formatting to StopWatch#getTime

----


> Add StopWatch#getTime with String Format Argument
> -------------------------------------------------
>
>                 Key: LANG-1236
>                 URL: https://issues.apache.org/jira/browse/LANG-1236
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.time.*
>            Reporter: Nick Manley
>            Priority: Minor
>
> Add a version of the StopWatch#getTime method which takes a String to format the time in the desired format.
> {code}
> StopWatch watch= StopWatch.createStarted();
> // sleep for 1 hour, 19 minutes, 45.554 seconds
> try {Thread.sleep(4785554);} catch (final InterruptedException ex) {}
> watch.stop();
> System.out.println(watch.getTime("HH:mm:ss.SSS");
> // prints: 1:19:45.554
> {code}
> I have a patch ready, but I wasn't sure if this kind of thing should be a part of the getTime method or if toString should be overloaded to take a format argument. Either way seems okay to me. I put it on getTime, but if there are disagreements about that, I would be okay with putting it in toString instead.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)