Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 4 May 2016 19:03:12 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12965011.1462377672000.111627.1462388592866@Atlassian.JIRA>
In-Reply-To: <JIRA.12965011.1462377672000@Atlassian.JIRA>
References: <JIRA.12965011.1462377672000@Atlassian.JIRA> <JIRA.12965011.1462377672742@arcas>
Subject: [jira] [Updated] (CRYPTO-52) Improve assertion message when test
 fails due to lack of JCE Unlimited Strength Jurisdiction Policy Files.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 04 May 2016 19:03:14 -0000


     [ https://issues.apache.org/jira/browse/CRYPTO-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated CRYPTO-52:
--------------------------------
    Attachment: CRYPTO-52.001.patch

bq. Why not just fix the test case?

Can you please describe what you mean by fixing the test case?  Are you saying don't use a large key length in the test, or skip the test on environments that can't support it by using JUnit {{assumeTrue}}, or something else?

Supporting an AES key length of 256 is an important use case for commons-crypto.  The test suite must cover this so that we check against potential bugs when using a key length of 256.  Fixing the test case must not sacrifice this test coverage.

{quote}
Does it really need a PR?
Seems overkill to me; JIRA is more than enough.
{quote}

It makes no difference to me.  I just followed the lead of prior CRYPTO JIRAs.  I have attached a patch file too for those who prefer that.


> Improve assertion message when test fails due to lack of JCE Unlimited Strength Jurisdiction Policy Files.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CRYPTO-52
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-52
>             Project: Commons Crypto
>          Issue Type: Improvement
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: CRYPTO-52.001.patch
>
>
> {{JceCipherTest}} requires support for an AES key length of 256.  This is only available if the runtime JDK has installed the JCE Unlimited Strength Jurisdiction Policy Files.  When the test fails, the reason isn't clear.  We can improve this by detecting the maximum allowed key length and showing a more descriptive assertion message.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)