commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-220) Possible more OO-like approach to DigestUtils
Date Wed, 18 May 2016 23:38:12 GMT

    [ https://issues.apache.org/jira/browse/CODEC-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290091#comment-15290091
] 

Sebb commented on CODEC-220:
----------------------------

Added initial fluent code design.
The names of the methods can obviously be changed at this point - e.g. the done() and asHex()
methods probably need renaming.
I deliberately did not add digest(data) and digestHex(data) methods as there would need to
be one for each data type.

URL: http://svn.apache.org/viewvc?rev=1744467&view=rev
Log:
CODEC-220 Fluent interface for DigestUtils

Modified:
    commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/DigestUtils.java
    commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java




> Possible more OO-like approach to DigestUtils
> ---------------------------------------------
>
>                 Key: CODEC-220
>                 URL: https://issues.apache.org/jira/browse/CODEC-220
>             Project: Commons Codec
>          Issue Type: Improvement
>            Reporter: Sebb
>            Assignee: Sebb
>         Attachments: MessageDigestHelper.java, MessageDigestHelper.java
>
>
> DigestUtils is starting to get a bit unwieldy with so many similar static methods.
> One approach would be to use a Fluent approach (method chaining).
> e.g. DigestUtils.with("My-Digest").digestHex(File f);
> There would only need to be digest,digestHex and update instance methods for the different
input types, currently byte, ByteBuffer, InputStream, File.
> Whereas at present these are repeated for each digest type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message