commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-354) PureJavaCrc32C constructor calls overrideable method
Date Mon, 16 May 2016 10:30:12 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284354#comment-15284354
] 

Sebb commented on COMPRESS-354:
-------------------------------

Already did:

https://issues.apache.org/jira/browse/HADOOP-13147

> PureJavaCrc32C constructor calls overrideable method
> ----------------------------------------------------
>
>                 Key: COMPRESS-354
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-354
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.12
>
>
> Constructors must not call overrideable methods.
> An object is not guaranteed fully constructed until the constructor exits, so the subclass
override may not see the proper parent object.
> In this case, the class is package-protected so it's possible to ensure that subclasses
don't override the method.
> However this would have to be checked, so it would be better to fix the issue:
> 1) make class final
> 2) make reset method final
> 3) extract the code into a private method that is used by the ctor and the public method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message