commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-211) Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms
Date Mon, 16 May 2016 22:42:12 GMT

    [ https://issues.apache.org/jira/browse/CODEC-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285571#comment-15285571
] 

Sebb commented on CODEC-211:
----------------------------

Yes, I know that there are some standard names, and there is a use case for having a class
which defines the algorithm names.

However, this class does not have to be an enum.

Given that there is already a class which defines the constants, there is no point replacing
this now with an enum.

What benefit does the enum provide that is not already provided by the constants class?
(Apart from easily listing the names)

I see only disadvantages for end users.

There is also a possibility that people might be confused having two different ways to define
algorithm names:
- as an enum (but only if it is a 'standard' name) or 
- using a String (which works for all algorithms).

> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms
> ------------------------------------------------------------------------------
>
>                 Key: CODEC-211
>                 URL: https://issues.apache.org/jira/browse/CODEC-211
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.10
>         Environment: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary Gregory
>            Assignee: Gary Gregory
>             Fix For: 1.11
>
>
> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message