commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1357) Create Github Pull Request Template
Date Sat, 14 May 2016 19:08:12 GMT

    [ https://issues.apache.org/jira/browse/MATH-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283648#comment-15283648
] 

Rob Tompkins commented on MATH-1357:
------------------------------------

Based on the conversation I think the small changes to the CONTRIBUTING.md that I've posted
here in the .patch file could suffice. If we wanted a heavier set of validations we might
write some sort of additional Jenkins job that builds pull requests and posts back to the
them the status of the potentially built code if we were to merge the changes in...or we could
rely on travis-ci for this. It seemed to be working there for a little while.

> Create Github Pull Request Template
> -----------------------------------
>
>                 Key: MATH-1357
>                 URL: https://issues.apache.org/jira/browse/MATH-1357
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.6.1
>            Reporter: Rob Tompkins
>            Priority: Trivial
>              Labels: github
>             Fix For: 4.0
>
>         Attachments: MATH-1357.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to have at the root of {{commons-math}} a directory named {{.github}} with
a file named {{PULL_REQUEST_TEMPLATE.md}} that automatically populates the body of pull requests.
> For example, angular.js has the following
> https://raw.githubusercontent.com/angular/angular.js/master/.github/PULL_REQUEST_TEMPLATE.md
> Further we can include anything between the delimiters {{<!--  Some comment here -->}}
will be seen by the github user opening the pull request, but not actually included in the
comment. For example consider the one on the spring-boot project:
> https://raw.githubusercontent.com/spring-projects/spring-boot/master/.github/PULL_REQUEST_TEMPLATE.md
> I would propose we have the following:
> * A link to the CONTRIBUTING.md file in the project, which explains how to contribute.
I would include this in the {{<!-- -->}} delimited section, as it is unnecessary to
actually persist into the github pull request comment body.
> * A request to link to a Jira ticket number (which is relatively trivial to include).
> * A checkbox for the apache contributor agreement having been signed and emailed in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message