commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-1341) "RandomDataGenerator" is brittle
Date Sun, 15 May 2016 23:32:12 GMT


Gilles commented on MATH-1341:

Code available in branch "feature-MATH-1341".

> "RandomDataGenerator" is brittle
> --------------------------------
>                 Key: MATH-1341
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Gilles
>            Priority: Minor
>              Labels: API, cleanup, deprecation, thread-safety
>             Fix For: 4.0
>         Attachments:
> Class {{RandomDataGenerator}} can easily be misused as it advertizes a method to access
its internal RNG (which is _not_ thread-safe).
> The class is also a mixed bag of "data generators" that are either "secure" or not.
> Moreover it uses the "lazy initialization" pattern (for the RNG instance) solely because
of this duality; otherwise users that need one or the other form of data generation will obviously
always use the RNG since all data generation methods need it.
> This entails also a performance hit (albeit tiny) as each call checks whether the RNG
has been initialized already.
> The clean solution would be to separate the two types of data generation (secure vs not)
into different classes.

This message was sent by Atlassian JIRA

View raw message