commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1228) First Moment is not public
Date Sat, 07 May 2016 11:22:13 GMT

    [ https://issues.apache.org/jira/browse/MATH-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275197#comment-15275197
] 

Gilles commented on MATH-1228:
------------------------------

Also please note that the same design is used throughout, as {{ThirdMoment}} and {{FourthMoment}}
are also "package-private".  Oddly, {{SecondMoment}} is public.
Having all of them public would just be a workaround; we should not leave the underlying design
issues unanswered. Now is a good time to fix things, e.g. also get rid of all these protected
fields (which is a goal in itself: MATH-758).

> First Moment is not public
> --------------------------
>
>                 Key: MATH-1228
>                 URL: https://issues.apache.org/jira/browse/MATH-1228
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.5
>            Reporter: Fabian Lange
>
> Hi there,
> is there a specific reason FirstMoment is not public?
> I want to calculate a mean over a List<Double>, for that I want to loop over that
list and invoke Mean.increment(listValue), however this is slower than it could be. Every
increment call makes a check to incMoment.
> I could avoid that if I use a FirstMoment directly, but I cannot create an instance,
because it is protected.
> Also this effectively means that the public constructor Mean(FirstMoment) is not usable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message