Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6843219B44 for ; Sat, 23 Apr 2016 17:56:28 +0000 (UTC) Received: (qmail 70524 invoked by uid 500); 23 Apr 2016 17:56:28 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 70419 invoked by uid 500); 23 Apr 2016 17:56:28 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 70408 invoked by uid 99); 23 Apr 2016 17:56:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Apr 2016 17:56:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CFC07DFE2E; Sat, 23 Apr 2016 17:56:27 +0000 (UTC) From: caseyscarborough To: issues@commons.apache.org Reply-To: issues@commons.apache.org Message-ID: Subject: [GitHub] commons-lang pull request: Add tests for missed branches in DateUt... Content-Type: text/plain Date: Sat, 23 Apr 2016 17:56:27 +0000 (UTC) GitHub user caseyscarborough opened a pull request: https://github.com/apache/commons-lang/pull/133 Add tests for missed branches in DateUtils Fixes a typo and adds tests for some missed branches in `DateUtils`. The `isSame` methods require both dates to be non-null. Previously breaking the check to allow one of the dates to be null didn't trigger a failing test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/caseyscarborough/commons-lang master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 ---- commit 1ecdf78a240d9894ca5e25fee49bb8a38aa08a0c Author: Casey Scarborough Date: 2016-04-23T17:46:21Z Add tests for missed branches in DateUtils ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---