Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38E5619758 for ; Fri, 29 Apr 2016 02:36:13 +0000 (UTC) Received: (qmail 30642 invoked by uid 500); 29 Apr 2016 02:36:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 30559 invoked by uid 500); 29 Apr 2016 02:36:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 30540 invoked by uid 99); 29 Apr 2016 02:36:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 02:36:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C7AAF2C14F4 for ; Fri, 29 Apr 2016 02:36:12 +0000 (UTC) Date: Fri, 29 Apr 2016 02:36:12 +0000 (UTC) From: "Jerry Chen (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRYPTO-33) SecureRandom shadows JVM class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRYPTO-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263434#comment-15263434 ] Jerry Chen commented on CRYPTO-33: ---------------------------------- When deciding the same name, we original has the same thoughts with Emmanuel Bourg. Unless, they use both Ciphers (Java Cipher and this Cipher) otherwise, developers will not has the same clashes. The both Cipher has similar functionality, the developers usually has no reason to use both Ciphers at same Java class. They will choose one or another. If we finally to rename, I think we should name all classes consistent instead change only those that conflicts. I consider the consistent names are very important for API usage. People will have no idea why the CryptoInputStream is named in this way while CTRCipherInputStream is named in another manner. > SecureRandom shadows JVM class > ------------------------------ > > Key: CRYPTO-33 > URL: https://issues.apache.org/jira/browse/CRYPTO-33 > Project: Commons Crypto > Issue Type: Bug > Reporter: Sebb > Assignee: Xianda Ke > > The SecureRandom interface also exists as a class in java.security. > This makes it awkward to use, for example in JavaSecureRandom the fully qualified name has to be used for the java class. > Ideally it should be renamed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)