Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 7 Apr 2016 21:55:25 +0000 (UTC)
From: "Gary Gregory (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12957032.1460065721000.168666.1460066125439@Atlassian.JIRA>
In-Reply-To: <JIRA.12957032.1460065721000@Atlassian.JIRA>
References: <JIRA.12957032.1460065721000@Atlassian.JIRA>
 <JIRA.12957032.1460065721618@arcas>
Subject: [jira] [Commented] (DBCP-458) Allow subclasses of BasicDataSource
 to provide their own GenericObjectPool implementation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DBCP-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231163#comment-15231163 ] 

Gary Gregory commented on DBCP-458:
-----------------------------------

Patches with unit tests are welcome ! ;-)

> Allow subclasses of BasicDataSource to provide their own GenericObjectPool implementation
> -----------------------------------------------------------------------------------------
>
>                 Key: DBCP-458
>                 URL: https://issues.apache.org/jira/browse/DBCP-458
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 2.1.1
>            Reporter: Adrian Tarau
>
> I had the same need in an older version and I had to do a terrible hack which I would not like to do with a newer version.
> The main idea is that I would like to be able to monitor borrow and return events (among other things) and for that I need to provide my own GenericObjectPool implementation.
> It would be a small change to add a createObjectPool method and use it in createConnectionPool. Default implementation would be to 
> {code}
> if (abandonedConfig != null &&
>                 (abandonedConfig.getRemoveAbandonedOnBorrow() ||
>                  abandonedConfig.getRemoveAbandonedOnMaintenance())) {
>             gop = new GenericObjectPool<>(factory, config, abandonedConfig);
>         }
>         else {
>             gop = new GenericObjectPool<>(factory, config);
>         }
> {code}
> Subclasses would have the flexibility to provide their own pool implementation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)