Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 600B5198F9 for ; Sat, 30 Apr 2016 00:20:13 +0000 (UTC) Received: (qmail 83915 invoked by uid 500); 30 Apr 2016 00:20:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 83814 invoked by uid 500); 30 Apr 2016 00:20:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 83798 invoked by uid 99); 30 Apr 2016 00:20:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Apr 2016 00:20:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CC0CA2C1F5C for ; Sat, 30 Apr 2016 00:20:12 +0000 (UTC) Date: Sat, 30 Apr 2016 00:20:12 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MATH-1290) Additions to Complex Utils; creation of conversion methods between Complex[], double[], float[], and interleaved arrays MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265001#comment-15265001 ] Gilles commented on MATH-1290: ------------------------------ {noformat} git pull https://github.com/ericbarnhill/commons-math.git feature-MATH-1290 {noformat} worked fine. Changes pushed to the branch "feature-MATH-1290". bq. ComplexUtilsTest now evaluates for 0 rather than ulp This is not the case in the code I pulled. However, the correct type ("1.0" vs "1.0f") is now used for the argument of {{Math.ulp}}. Let me know whether you want to use that branch for additional work or whether it's OK to merge into "develop" (after a few days has elapsed to let reviewers provide feedback). > Additions to Complex Utils; creation of conversion methods between Complex[], double[], float[], and interleaved arrays > ----------------------------------------------------------------------------------------------------------------------- > > Key: MATH-1290 > URL: https://issues.apache.org/jira/browse/MATH-1290 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.5 > Reporter: Eric Barnhill > Priority: Minor > Labels: newbie, patch > Fix For: 4.0 > > Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java, ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java > > Original Estimate: 24h > Remaining Estimate: 24h > > I propose to add several new methods to the ComplexUtils class enabling easy conversion between Complex[] arrays, real or imaginary double[] or float[] arrays, and interleaved complex double[] or float[] arrays. The last two in particular are beneficial to have for OpenCL implementations and the JTransforms library. -- This message was sent by Atlassian JIRA (v6.3.4#6332)