Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D0FF19307 for ; Mon, 25 Apr 2016 21:40:13 +0000 (UTC) Received: (qmail 76857 invoked by uid 500); 25 Apr 2016 21:40:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 76736 invoked by uid 500); 25 Apr 2016 21:40:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 76634 invoked by uid 99); 25 Apr 2016 21:40:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 21:40:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DAB092C1F64 for ; Mon, 25 Apr 2016 21:40:12 +0000 (UTC) Date: Mon, 25 Apr 2016 21:40:12 +0000 (UTC) From: "Gary Gregory (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1134) New methods for lang3.Validate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257098#comment-15257098 ] Gary Gregory commented on LANG-1134: ------------------------------------ IMO, the whole class should be deprecated and moved to [validator]. It is confusing and lame IMO that we have two validation thingies in Commons. > New methods for lang3.Validate > ------------------------------ > > Key: LANG-1134 > URL: https://issues.apache.org/jira/browse/LANG-1134 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Affects Versions: 3.4 > Reporter: Stardust > Assignee: Charles Honton > Priority: Minor > Fix For: Review Patch, 3.5 > > > These are suggestions for new methods for the Validate class. > h1. Floating point values > h2. notNaN(value) > Throws an exception if value != value . > {code}double value; > value = Double.NaN; > Validate.notNaN(value); // Throws exception > value = 1.0; > Validate.notNaN(value); // Validates > value = Double.POSITIVE_INFINITY; > Validate.notNaN(value); // Validates{code} > h2. finite(value) > Validates that the argument contains a numeric value (not NaN or infinite). > {code}double value; > value = Double.NaN; > Validate.finite(value); // Throws exception > value = Double.POSITIVE_INFINITY; > Validate.finite(value); // Throws exception > value = 1.0; > Validate.finite(value); // Validates{code} > h1. Integers and floats > The following methods are overloaded to accept both integers and floating point values. > h2. greater(reference, value), greaterOrEqual(reference, value) > Ensures the argument is greater than (or equal to) a given value. > {code}double value; > value = 0.0; > Validate.greater(0.0, value); // Throws exception > Validate.greaterOrEqual(0.0, value); // Validates > value = Double.POSITIVE_INFINITY; > Validate.greater(0.0, value); // Validates > value = Double.NaN; > Validate.greater(0.0, value); // Throws exception{code} > h2. smaller(reference, value), smallerOrEqual(reference, value) > Ensures the argument is smaller than (or equal to) a given value. Does the opposite of greater(), see example above. > h2. different(reference, value) > Ensures the argument is not equal to a given value. A typical use case would be to accept only non-zero values. > {code}double value; > value = 0.0; > Validate.different(0.0, value); // Throws exception > Validate.different(1.0, value); // Validates > value = Double.NaN; > Validate.different(0.0, value); // Validates{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)