Return-Path: 
 <issues-return-53164-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EF5871971A
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Wed, 13 Apr 2016 21:17:27 +0000 (UTC)
Received: (qmail 93838 invoked by uid 500); 13 Apr 2016 21:17:27 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 93751 invoked by uid 500); 13 Apr 2016 21:17:27 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 93737 invoked by uid 99); 13 Apr 2016 21:17:27 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 21:17:27 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 51E05DFBA0; Wed, 13 Apr 2016 21:17:27 +0000 (UTC)
From: garydgregory <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-108-commons-lang@git.apache.org>
In-Reply-To: <git-pr-108-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request: LANG-781 Added methods to
 ObjectUtils c...
Content-Type: text/plain
Message-Id: <20160413211727.51E05DFBA0@git1-us-west.apache.org>
Date: Wed, 13 Apr 2016 21:17:27 +0000 (UTC)

Github user garydgregory commented on the pull request:

    https://github.com/apache/commons-lang/pull/108#issuecomment-209650500
  
    Yes:
    - Thank you for the patch.
    - The Javadoc has some bogus text, like starting with "<p></p>". You do not need that.
    - Do not use a for-each loop to traverse an array. This creates an iterator when none is needed. Use a normal for loop, which will not create the extra Iterator to GC. This matters when a libraries is used on the critical path and/or environments trying to do low/no GC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---