commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <>
Subject [jira] [Commented] (MATH-1357) Create Github Pull Request Template
Date Mon, 25 Apr 2016 12:33:12 GMT


Rob Tompkins commented on MATH-1357:

Github provides the mechanics to fire an http request anywhere we want at time of a pull request
opening or changing. In the past I have created a completely separate jenkins job that handles
all the pull request validation. Then that job sends another http request back to the pull
request stating what checks pass and/or fail.

The status checks then show up on the pull request similar to the way the travis-ci checks
show up on Eric's original PR:

> Create Github Pull Request Template
> -----------------------------------
>                 Key: MATH-1357
>                 URL:
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.6.1
>            Reporter: Rob Tompkins
>            Priority: Trivial
>              Labels: github
>             Fix For: 3.7
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> I would like to have at the root of {{commons-math}} a directory named {{.github}} with
a file named {{}} that automatically populates the body of pull requests.
> For example, angular.js has the following
> Further we can include anything between the delimiters {{<!--  Some comment here -->}}
will be seen by the github user opening the pull request, but not actually included in the
comment. For example consider the one on the spring-boot project:
> I would propose we have the following:
> * A link to the file in the project, which explains how to contribute.
I would include this in the {{<!-- -->}} delimited section, as it is unnecessary to
actually persist into the github pull request comment body.
> * A request to link to a Jira ticket number (which is relatively trivial to include).
> * A checkbox for the apache contributor agreement having been signed and emailed in.

This message was sent by Atlassian JIRA

View raw message