commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1357) Create Github Pull Request Template
Date Mon, 25 Apr 2016 12:33:12 GMT

    [ https://issues.apache.org/jira/browse/MATH-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256281#comment-15256281
] 

Rob Tompkins commented on MATH-1357:
------------------------------------

Github provides the mechanics to fire an http request anywhere we want at time of a pull request
opening or changing. In the past I have created a completely separate jenkins job that handles
all the pull request validation. Then that job sends another http request back to the pull
request stating what checks pass and/or fail.

The status checks then show up on the pull request similar to the way the travis-ci checks
show up on Eric's original PR:

https://github.com/apache/commons-math/pull/28


> Create Github Pull Request Template
> -----------------------------------
>
>                 Key: MATH-1357
>                 URL: https://issues.apache.org/jira/browse/MATH-1357
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.6.1
>            Reporter: Rob Tompkins
>            Priority: Trivial
>              Labels: github
>             Fix For: 3.7
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I would like to have at the root of {{commons-math}} a directory named {{.github}} with
a file named {{PULL_REQUEST_TEMPLATE.md}} that automatically populates the body of pull requests.
> For example, angular.js has the following
> https://raw.githubusercontent.com/angular/angular.js/master/.github/PULL_REQUEST_TEMPLATE.md
> Further we can include anything between the delimiters {{<!--  Some comment here -->}}
will be seen by the github user opening the pull request, but not actually included in the
comment. For example consider the one on the spring-boot project:
> https://raw.githubusercontent.com/spring-projects/spring-boot/master/.github/PULL_REQUEST_TEMPLATE.md
> I would propose we have the following:
> * A link to the CONTRIBUTING.md file in the project, which explains how to contribute.
I would include this in the {{<!-- -->}} delimited section, as it is unnecessary to
actually persist into the github pull request comment body.
> * A request to link to a Jira ticket number (which is relatively trivial to include).
> * A checkbox for the apache contributor agreement having been signed and emailed in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message