commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Barnhill (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1290) Additions to Complex Utils; creation of conversion methods between Complex[], double[], float[], and interleaved arrays
Date Tue, 19 Apr 2016 20:11:25 GMT

    [ https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248523#comment-15248523
] 

Eric Barnhill commented on MATH-1290:
-------------------------------------

Thanks Gilles.

I have done the following which I thought would be the most expeditious:
- backed up the four changed files
- deleted my old fork
- opened up a fresh fork
- copied the changed files one at a time into the new fork
- after each file, I committed so that each file has a commit message addressing its edits
in the log
- merged these changes into the branch, so that the branch feature-MATH-1290 on my fork is
now ahead of your and should pull fine

Regarding the interpolators: My apologies. I have indeed been playing around with the interpolators
(I loosened them up so they would extrapolate for me too) but thought I had done that in an
entirely separate project. For this reason I just deleted the old fork, and only copied in
the four files I have been patching, and this should be a clean pull.

Regarding the change to Math.ulp, I only did it for cosmetic reasons listed in an earlier
patch. I don't agree that anything has changed, the Math.ulp will just cast the 1 to 1.0 or
1.0f anyway, and use the ulp for the relevant primitive. I changed those values from 1 to
1.0 in an earlier patch, because I thought they were causing an error message, but I was not
right, so I just put them back.

You should get a clean pull and hopefully you find the commit log and diff files suitably
well documented. I also ran mvn clean verify.

> Additions to Complex Utils; creation of conversion methods between Complex[], double[],
float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-1290
>                 URL: https://issues.apache.org/jira/browse/MATH-1290
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.5
>            Reporter: Eric Barnhill
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: 4.0
>
>         Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
LaguerreSolver.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy conversion
between Complex[] arrays, real or imaginary double[] or float[] arrays, and interleaved complex
double[] or float[] arrays. The last two in particular are beneficial to have for OpenCL implementations
and the JTransforms library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message