commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1290) Additions to Complex Utils; creation of conversion methods between Complex[], double[], float[], and interleaved arrays
Date Sat, 09 Apr 2016 16:57:25 GMT

    [ https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233634#comment-15233634
] 

Gilles commented on MATH-1290:
------------------------------

Sorry to insist, but I maintain that using "git" cannot be be as complicated as you describe
above, from the perspective of a project's committer who has to update a repository on behalf
of many contributors (who don't have write access to that repository).

I have now made the experiment; and what I wrote above definitely works, implying that a _single
command_ on my part is enough to import contributions. This is shown in the following.

Command issued on the contributor's (say Eric) working copy
{noformat}
$ git branch -a
* PR-test
  master
  remotes/ulb.git/PR-test
  remotes/ulb.git/master
{noformat}

As you see above
* the contributor has set up a public repository named "ulb.git"
* he has pushed a branch "PR-test" with code which he wants a peer (say Gilles) to import.

Eric would issue the command
{noformat}
$ git request-pull HEAD ssh://eric@example.com/var/opt/git/ulb.git PR-test
{noformat}
resulting in an output similar to the following
{noformat}
The following changes since commit 563af00403a8eb39a54d63212a65c1b809604c93:

  A commit for testing a pull request. (2016-04-09 17:37:10 +0200)

are available in the git repository at:

  ssh://example.com/var/opt/git/ulb.git PR-test

for you to fetch changes up to 563af00403a8eb39a54d63212a65c1b809604c93:

  A commit for testing a pull request. (2016-04-09 17:37:10 +0200)

----------------------------------------------------------------
{noformat}

Of course, the details will slightly vary if you work with Github (instead of accessing the
public repository through ssh, as I did in this experiment).
But in the end, I need the equivalent of the advertized URL.

In my local copy, I'd then do
{noformat}
$ git checkout -b from-PR-test
$ git pull ssh://example.com/var/opt/git/ulb.git PR-test
{noformat}
And it will import Eric's "PR-test" branch into my "from-PR-test".  Again I'll use whatever
access the public repository provides (so the URL will vary slightly).


> Additions to Complex Utils; creation of conversion methods between Complex[], double[],
float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-1290
>                 URL: https://issues.apache.org/jira/browse/MATH-1290
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.5
>            Reporter: Eric Barnhill
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: 4.0
>
>         Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
LaguerreSolver.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy conversion
between Complex[] arrays, real or imaginary double[] or float[] arrays, and interleaved complex
double[] or float[] arrays. The last two in particular are beneficial to have for OpenCL implementations
and the JTransforms library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message