commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-207) add notifier support for new block in BZip2CompressorInputStream
Date Sun, 27 Mar 2016 17:00:26 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213538#comment-15213538
] 

Stefan Bodewig commented on COMPRESS-207:
-----------------------------------------

> regarding the bsGetBit change: what's a heads-up?

you could have warned us there were other changes. No harm done. I'm not convinced the extra
{{initBlock}} call is correct, could you explain why you think it is needed?

Your use case for {{resetBlock}} makes me think you won't like the events I suggest as they
don't give you the exact position on the underlying stream at all. Of course this could be
added. I've reused what we return in {{getBytesRead}}, which counts the uncompressed bytes.



> add notifier support for new block in BZip2CompressorInputStream
> ----------------------------------------------------------------
>
>                 Key: COMPRESS-207
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-207
>             Project: Commons Compress
>          Issue Type: New Feature
>          Components: Compressors
>    Affects Versions: 1.4.1
>            Reporter: Thomas Meyer
>            Priority: Minor
>              Labels: API, bzip
>         Attachments: 0001-Add-notifier-support-for-new-block-in-BZip2Compresso.patch,
BZip2CompressorInputStream-add-newBlock-notifier.patch, BZip2CompressorInputStream-add-newBlock-notifier.patch,
BZip2CompressorInputStream-add-newBlock-notifier.patch
>
>
> hi,
> attached patch enables an program to add a listener when a new bzip2
> block is detected.
> The notifier is called with:
>  - xxx.newBlock(this, currBlockPosition)
> - this = the current BZip2CompressorInputStream object
> - currBlockPosition = The offset (i.e. start position) in the compressed
> input stream of the current block



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message