commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (JEXL-188) Possible bug in JexlArithmetic.isFloatingPointNumber
Date Tue, 23 Feb 2016 18:03:18 GMT

     [ https://issues.apache.org/jira/browse/JEXL-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Henri Biestro resolved JEXL-188.
--------------------------------
    Resolution: Fixed

src/main/java/org/apache/commons/jexl3/JexlArithmetic.java
src/test/java/org/apache/commons/jexl3/ArithmeticTest.java
Committed revision 1731915.

> Possible bug in JexlArithmetic.isFloatingPointNumber
> ----------------------------------------------------
>
>                 Key: JEXL-188
>                 URL: https://issues.apache.org/jira/browse/JEXL-188
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Dmitri Blinov
>            Assignee: Henri Biestro
>            Priority: Trivial
>             Fix For: 3.1
>
>
> Reported by FindBugs is the message 
> "Useless condition: it's known that ch <= '9' at this point"   
> {code}
> if (ch != '+' && ch != '-' && ch < '0' && ch > '9') 
> {\code}
> Possibly && (ch < '0' || ch > '9') was meant ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message