commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Vandahl (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (JCS-159) BlockDiskCache overwrites data after loading from disk
Date Sat, 06 Feb 2016 18:41:39 GMT

     [ https://issues.apache.org/jira/browse/JCS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Vandahl resolved JCS-159.
--------------------------------
       Resolution: Fixed
    Fix Version/s: jcs-2.0-beta-2

Patches applied.

The verification of the key hash broke the test that wrote empty int blocks into the file.
Although we value your contributions, please do not expect us to always debug tests for you
(which I did here).

> BlockDiskCache overwrites data after loading from disk
> ------------------------------------------------------
>
>                 Key: JCS-159
>                 URL: https://issues.apache.org/jira/browse/JCS-159
>             Project: Commons JCS
>          Issue Type: Bug
>          Components: Indexed Disk Cache
>    Affects Versions: jcs-2.0-beta-1
>            Reporter: Wiktor N
>            Assignee: Thomas Vandahl
>             Fix For: jcs-2.0-beta-2
>
>         Attachments: fix-BlockDisk.java.patch, unittest-BlockDiskCacheUnitTestAbstract.java.patch,
verify-BlockDiskKeyStore.java.patch
>
>
> BlockDiskCache overwrites data, that were loaded from disk, so when they are written
back to disk and accessed again - cache is corrupt.
> See the test case patch below for reproduction.
> I've also attached patch for BlockDiskCacheKeyStore verification. It validates, that
all blocks belong only to one key.
> I've also proposed a patch to fix this, but it breaks some other unit test. I haven't
check them, so I'm not sure, if this is correct approach



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message