Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
From: PascalSchumacher <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-113-commons-lang@git.apache.org>
In-Reply-To: <git-pr-113-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request: LANG-1184:
 StringUtils#normalizeSpace n...
Content-Type: text/plain
Message-Id: <20160117173954.4F221E03CD@git1-us-west.apache.org>
Date: Sun, 17 Jan 2016 17:39:54 +0000 (UTC)

Github user PascalSchumacher commented on the pull request:

    https://github.com/apache/commons-lang/pull/113#issuecomment-172357021
  
    @hen  Thanks again for the in-depth review.
    
    Part of the is `isEmpty()` is necessary, because `normalizeSpace` has to return `null` for `null` parameters according to javadoc `@return the modified string with whitespace normalized, {@code null} if null String input`
    
    I have updated the pull request and replaced the is `isEmpty()` check by `str == null`.
    
    I have also updated javadoc to reflect that non-breaking space is normalized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---