commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (EXEC-64) DefaultExecutor line 372 swallows IOException cause instead of propagating it
Date Sat, 09 Jan 2016 16:50:39 GMT

     [ https://issues.apache.org/jira/browse/EXEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb updated EXEC-64:
---------------------
    Affects Version/s:     (was: 1.1)
                       1.3

> DefaultExecutor line 372 swallows IOException cause instead of propagating it
> -----------------------------------------------------------------------------
>
>                 Key: EXEC-64
>                 URL: https://issues.apache.org/jira/browse/EXEC-64
>             Project: Commons Exec
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Michael Vorburger
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: exec-64.patch
>
>
> DefaultExecutor line 372 does:
> {noformat}
>                 } catch (Exception e) {
>                     throw new IOException(e.getMessage());
>                 }
> {noformat}
> when it may be better to do:
> {noformat}
>                 } catch (Exception e) {
>                     throw new IOException(e.getMessage(), e);
>                 }
> {noformat}
> This didn't cause any real issues for me - I just came across it as I was browsing the
Commons Exec source, in the context of implementing a launch helper (BTW: see https://github.com/vorburger/MariaDB4j/blob/master/src/main/java/ch/vorburger/exec/ManagedProcess.java
- would that, once further cleaned-up, potentially be something of any interest to you for
integration into Commons Exec?).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message