Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 25 Oct 2015 19:36:27 +0000 (UTC)
From: "Anthony Whitford (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12907769.1445801749000.54592.1445801787672@Atlassian.JIRA>
In-Reply-To: <JIRA.12907769.1445801749000@Atlassian.JIRA>
References: <JIRA.12907769.1445801749000@Atlassian.JIRA>
 <JIRA.12907769.1445801749585@arcas>
Subject: [jira] [Created] (POOL-306) BaseGenericObjectPool IdentityWrapper
 equals violates Java spec
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Anthony Whitford created POOL-306:
-------------------------------------

             Summary: BaseGenericObjectPool IdentityWrapper equals violates Java spec
                 Key: POOL-306
                 URL: https://issues.apache.org/jira/browse/POOL-306
             Project: Commons Pool
          Issue Type: Bug
    Affects Versions: 2.4.2
            Reporter: Anthony Whitford
            Priority: Minor


Noticed that the {{equals}} implementation assumes the {{other}} parameter can be successfully cast to {{IdentityWrapper}}:
{code}
        @Override
        @SuppressWarnings("rawtypes")
        public boolean equals(Object other) {
            return ((IdentityWrapper) other).instance == instance;
        }
{code}

(There is a chance that this could throw a {{ClassCastException}}.)

See [BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS|http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS].

I recommend:
{code}
        @Override
        @SuppressWarnings("rawtypes")
        public boolean equals(Object other) {
            return other instanceof IdentityWrapper && ((IdentityWrapper) other).instance == instance;
        }
{code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)