commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Weygandt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONFIGURATION-612) BuilderConfigurationWrapperFactory should support ImmutableConfiguration
Date Fri, 02 Oct 2015 18:18:26 GMT

    [ https://issues.apache.org/jira/browse/CONFIGURATION-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941520#comment-14941520
] 

Jon Weygandt commented on CONFIGURATION-612:
--------------------------------------------

When building it in a clean environment there was one glitch that needed an explicit cast
in MultiFileConfigurationBuilderProvider.java. (Eclipse was OK, and even "mvn install" over
a previous build, but "mvn clean install" had issues)

Also when building on Linux "new File("this is/<certainly>\\an#invalid#*path!")" is
actually a valid file name and the test fails. I believe the only character you cannot put
in a Linux file name is "/", and when you use it in this context, it is a directory separator
so it is valid. For the patch I commented out the test.

My info:
Jon Weygandt
jweygandt@ebay.com
eBay Inc

> BuilderConfigurationWrapperFactory should support ImmutableConfiguration
> ------------------------------------------------------------------------
>
>                 Key: CONFIGURATION-612
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-612
>             Project: Commons Configuration
>          Issue Type: Improvement
>            Reporter: Jon Weygandt
>         Attachments: CONFIGURATION-612-v2.patch, CONFIGURATION-612.patch
>
>
> Since ImmutableConfigurations have been introduced in 2.0, the BuilderConfigurationWrapperFactory
should support these types.
> The patch attached to this issue changes BuilderConfigurationWrapperFactory.createBuilderConfigurationWrapper's
T to <T extends ImmutableConfiguration> along with the ripple of changes to associated
classes.
> Also updated is the documentation on the use of the wrapper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message