commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From britter <...@git.apache.org>
Subject [GitHub] commons-lang pull request:
Date Wed, 21 Oct 2015 06:43:12 GMT
Github user britter commented on the pull request:

    https://github.com/apache/commons-lang/commit/131917a0d3303ca2c38fd1d6765b9bed2c23ff89#commitcomment-13893327
  
    In src/test/java/org/apache/commons/lang3/StringUtilsTest.java:
    In src/test/java/org/apache/commons/lang3/StringUtilsTest.java on line 2394:
    JUnit tests should never write to std out, because that will obscure test reports generated
by tools like maven. When running `mvn test` all you want to see is whether all tests have
passed or not.
    
    Further more in this case you've already made explicit which methods are excluded by defining
the `excludeMethods` array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message