commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Eckenfels (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-559) FTPClientWrapper is not robust against some failures
Date Wed, 23 Sep 2015 20:01:05 GMT

    [ https://issues.apache.org/jira/browse/VFS-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905141#comment-14905141
] 

Bernd Eckenfels commented on VFS-559:
-------------------------------------

Can you confirm this is fixed with VFS-567 in this commit: http://svn.apache.org/viewvc?rev=1704927&view=rev

> FTPClientWrapper is not robust against some failures
> ----------------------------------------------------
>
>                 Key: VFS-559
>                 URL: https://issues.apache.org/jira/browse/VFS-559
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: L
>
> The goal of the class is stated in javadoc:
> A wrapper to the FTPClient to allow automatic reconnect on connection loss.
> A lot of its methods look like :
>         try
>         {
>             do something...
>         }
>         catch (final IOException e)
>         {
>             disconnect();
>             try to repeat the operation...
>         }
> Unfortunately disonnect() can fail for the same reason as the original "do something".
In my case it as a "connection reset". So instead of the original exception I was getting
more or less the same exception from getFtpClient().quit();
> So the wrapper did not help at all.
> I guess all the disconnect() invocations must also be inside try/catch so that even if
disconnect() throws, the method goes on to the next step:  try to repeat the operation...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message