Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45F0D18EF1 for ; Wed, 19 Aug 2015 21:46:46 +0000 (UTC) Received: (qmail 990 invoked by uid 500); 19 Aug 2015 21:46:46 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 892 invoked by uid 500); 19 Aug 2015 21:46:46 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 880 invoked by uid 99); 19 Aug 2015 21:46:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 21:46:46 +0000 Date: Wed, 19 Aug 2015 21:46:45 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BCEL-242) Remove Serializable, Clonable, hashCode, equals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BCEL-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703794#comment-14703794 ] Sebb commented on BCEL-242: --------------------------- It's not possible to make most classes immutable, as in the current design that does not make it easy to modify class files. > Remove Serializable, Clonable, hashCode, equals > ----------------------------------------------- > > Key: BCEL-242 > URL: https://issues.apache.org/jira/browse/BCEL-242 > Project: Commons BCEL > Issue Type: Wish > Reporter: Charles Honton > > While we're in the midst of bringing BCEL up to date, can we remove the unnecessary code. > It is unlikely that any application needs to serialize BCEL state and the class that BCEL generates is already "serialized". (And serializatoin is hard to get right) > It is unlikely that opcodes or instructions need to be compared, so equals/hashCode is excess. > Cloning is hard to get right and probably not necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)