commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunel Jahangirova (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1258) compute() method in classes in org.apache.commons.math4.ml.distance package
Date Wed, 19 Aug 2015 13:17:46 GMT

    [ https://issues.apache.org/jira/browse/MATH-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702995#comment-14702995
] 

Gunel Jahangirova commented on MATH-1258:
-----------------------------------------

Hi!

Well, it is good that documentation states that, but why not to add a simple check into the
code which will throw an exception with a meaningful message?

> compute() method in classes in org.apache.commons.math4.ml.distance package
> ---------------------------------------------------------------------------
>
>                 Key: MATH-1258
>                 URL: https://issues.apache.org/jira/browse/MATH-1258
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Gunel Jahangirova
>            Priority: Minor
>
> Hi!
> There are five classes CanberraDistance, ChebyshevDistance, EarthMoversDistance, EuclideanDistance
and ManhattanDistance in org.apache.commons.math4.ml.distance package, which compute different
types of distances. Each of them contains method compute(double[] a, double[] b) that accepts
two double arrays as variables.
> However, if the lengths of array a is greater than the length of array b, the method
compute() in all the five classes produces java.lang.ArrayIndexOutOfBoundsException.
> For example,
>          private void test0() {
>            CanberraDistance distance = new CanberraDistance();
>     
>             final double[] a = { 1, 2, 3, 4, 9, 4 };
>             final double[] b = { -5, -6, 7, 4, 3 };
>             distance.compute(a, b);
>        }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message