commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-233) The access_flags field in AccessFlags class should be final
Date Fri, 14 Aug 2015 21:07:46 GMT

    [ https://issues.apache.org/jira/browse/BCEL-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697753#comment-14697753
] 

Mark Roberts commented on BCEL-233:
-----------------------------------

I need the ability to set the flags.   For example, I used to be able to set the ACC_PUBLIC
flag.  How is this supposed to be done now?

> The access_flags field in AccessFlags class should be final
> -----------------------------------------------------------
>
>                 Key: BCEL-233
>                 URL: https://issues.apache.org/jira/browse/BCEL-233
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 6.0
>
>
> The access_flags field in the AccessFlags class should be final.
> It is currently not set by any other classes outside their constructors.
> The public setters - e.g. isPrivate(boolean) - are not used and should be deleted. [Apart
from that, their names are really confusing.]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message