commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BCEL-233) The access_flags field in AccessFlags class should be final
Date Wed, 12 Aug 2015 12:52:45 GMT

     [ https://issues.apache.org/jira/browse/BCEL-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved BCEL-233.
-----------------------
       Resolution: Fixed
    Fix Version/s: 6.0

URL: http://svn.apache.org/r1695497
Log:
BCEL-233 The access_flags field in AccessFlags class should be final

Modified:
    commons/proper/bcel/trunk/src/changes/changes.xml
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AccessFlags.java


> The access_flags field in AccessFlags class should be final
> -----------------------------------------------------------
>
>                 Key: BCEL-233
>                 URL: https://issues.apache.org/jira/browse/BCEL-233
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 6.0
>
>
> The access_flags field in the AccessFlags class should be final.
> It is currently not set by any other classes outside their constructors.
> The public setters - e.g. isPrivate(boolean) - are not used and should be deleted. [Apart
from that, their names are really confusing.]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message