commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
Date Sun, 09 Aug 2015 14:55:45 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Bodewig updated COMPRESS-300:
------------------------------------
    Attachment: COMPRESS-300-alternative.patch
                imaging-compress-lzw-adjusted.patch

This is an updated by patch of mine and an adjustment of [~damjan]'s patch to imaging.

Thanks a lot Damjan.  Your patch has shown that you didn't need more than what [~sebb@apache.org]'s
patch would have allowed you to - so I've cut back on my changes.  The patch to imaging applies
cleanly and builds against the patched compress with all unit tests passing.

The main difference between my updated patch and Sebb's original are a few names and extracting
a few constants.  Unless anybody yells I plan to apply the patch to Commons during the coming
week and call for a release shortly thereafter.

> LZWInputStream has mutable protected fields; these should be accessed via getter/setter
and made private
> --------------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-300
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-300
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: COMPRESS-300-alternative.patch, COMPRESS-300.patch, imaging-compress-lzw-adjusted.patch,
imaging-compress-lzw.patch
>
>
> As per the discussion on the dev list, the class LZWInputStream has some non-private
mutable fields.
> These should be accessed via getters/setters only (data encapsulation).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message