commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn He (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IO-279) Tailer erroneously considers file as new
Date Thu, 13 Aug 2015 22:04:46 GMT

    [ https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695997#comment-14695997
] 

Shawn He edited comment on IO-279 at 8/13/15 10:04 PM:
-------------------------------------------------------

I am encountering the same issue with commons-io 2.4 and using the Tailer class. I assume
we could manually build a commons-io class and use that in Java before an official release
comes out with a patch suggested by the above two people.


was (Author: shawnhe):
I am encountering the same issue with commons-io 2.4 and using the Tailer class. I assume
we can't manually build a commons-io class and use that in Java, then what would be the choice
other than totally abandoning the use of the class? 

> Tailer erroneously considers file as new
> ----------------------------------------
>
>                 Key: IO-279
>                 URL: https://issues.apache.org/jira/browse/IO-279
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 2.0.1, 2.4
>            Reporter: Sergio Bossa
>         Attachments: IO-279.patch, disable_resetting.patch, fix-tailer.patch, modify-test-fixed.patch,
modify-test.patch
>
>
> Tailer sometimes erroneously considers the tailed file as new, forcing a repositioning
at the start of the file: I'm still unable to reproduce this in a test case, because it only
happens to me with huge log files during Apache Tomcat startup.
> This is the piece of code causing the problem:
> {code}
> // See if the file needs to be read again
> if (length > position) {
>     // The file has more content than it did last time
>     last = System.currentTimeMillis();
>     position = readLines(reader);
> } else if (FileUtils.isFileNewer(file, last)) {
>     /* This can happen if the file is truncated or overwritten
>         * with the exact same length of information. In cases like
>         * this, the file position needs to be reset
>         */
>     position = 0;
>     reader.seek(position); // cannot be null here
>     // Now we can read new lines
>     last = System.currentTimeMillis();
>     position = readLines(reader);
> }
> {code}
> What probably happens is that the new file content is about to be written on disk, the
date is already updated but content is still not flushed, so actual length is untouched and
there you go.
> In other words, I think there should be some better method to verify the condition above,
rather than relying only on dates: keeping and comparing the hash code of the latest line
may be a solution, but may hurt performances ... other ideas?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message