Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D7271800E for ; Thu, 16 Jul 2015 19:38:05 +0000 (UTC) Received: (qmail 17538 invoked by uid 500); 16 Jul 2015 19:38:04 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 17410 invoked by uid 500); 16 Jul 2015 19:38:04 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 17052 invoked by uid 99); 16 Jul 2015 19:38:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 19:38:04 +0000 Date: Thu, 16 Jul 2015 19:38:04 +0000 (UTC) From: "Justin Cranford (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DBCP-441) Update DBCP2 configuration web page to add 3 missing properties from BasicDataSource API and BasicDataSourceFactory config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DBCP-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Cranford updated DBCP-441: --------------------------------- Description: This web page documents DBCP 2 configuration properties: http://commons.apache.org/proper/commons-dbcp/configuration.html I compared the listed properties to DBCP 2.1 classes BasicDataSource and BasicDataSourceFactory. I noticed 5 configuration properties supported by the code which are missing from the DBCP configuration web page. Please add these properties to the configuration documentation. Thank you. 1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 4) validationQueryTimeout - mentioned in DBCP-163 and DBCP-226, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 5) defaultQueryTimeout - mentioned in DBCP-340, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking which passes a configuration option to Commons Pool 2. This option is only available in BasicDataSource API, not in BasicDataSourceFactory config, so I am not sure if it was intentionally left out of BasicDataSourceFactory and the DBCP configuration web page. was: This web page documents DBCP 2 configuration properties: http://commons.apache.org/proper/commons-dbcp/configuration.html I compared the listed properties to DBCP 2.1 classes BasicDataSource and BasicDataSourceFactory. There are 3 configuration properties supported by the code which are missing from the DBCP configuration web page. Please add these properties to the configuration documentation. Thank you. 1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page 3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking which passes a configuration option to Commons Pool 2. This option is only available in BasicDataSource API, not in BasicDataSourceFactory config, so I am not sure if it was intentionally left out of BasicDataSourceFactory and the DBCP configuration web page. > Update DBCP2 configuration web page to add 3 missing properties from BasicDataSource API and BasicDataSourceFactory config > -------------------------------------------------------------------------------------------------------------------------- > > Key: DBCP-441 > URL: https://issues.apache.org/jira/browse/DBCP-441 > Project: Commons Dbcp > Issue Type: Bug > Affects Versions: 2.1 > Environment: http://commons.apache.org/proper/commons-dbcp/configuration.html > Reporter: Justin Cranford > Priority: Minor > Labels: documentation, easyfix > > This web page documents DBCP 2 configuration properties: > http://commons.apache.org/proper/commons-dbcp/configuration.html > I compared the listed properties to DBCP 2.1 classes BasicDataSource and BasicDataSourceFactory. I noticed 5 configuration properties supported by the code which are missing from the DBCP configuration web page. Please add these properties to the configuration documentation. Thank you. > 1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page > 2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page > 3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page > 4) validationQueryTimeout - mentioned in DBCP-163 and DBCP-226, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page > 5) defaultQueryTimeout - mentioned in DBCP-340, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page > Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking which passes a configuration option to Commons Pool 2. This option is only available in BasicDataSource API, not in BasicDataSourceFactory config, so I am not sure if it was intentionally left out of BasicDataSourceFactory and the DBCP configuration web page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)